docs: local setup notes #5974
Merged
docs: local setup notes #5974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danstarns
commented
Jun 28, 2024
| This is a Node.js project and you need to have Node.js installed on your machine. You can download it from [here](https://nodejs.org/). We test versions 14 and 16 of Node in the CI, so it's recommended to use one of these versions, or the latest of: 16.20.2 | ||
|
|
||
| ```bash | ||
| nvm use 16.20.2 |
There was a problem hiding this comment.
RE discussion, we should use this version locally to ensure consistent machine to CI.
16.20.2 comes from the latest 16 in https://nodejs.org/en/about/previous-releases and satisfies the node-version: [14.17, 16.x] matrix in the CI test runner.
There was a problem hiding this comment.
🙇♂️
Based on the releases, we should probably switch to [20.x, 22.x] soon.
artf
approved these changes
Jun 30, 2024
|
Nice addition @danstarns Thank you |
This was referenced Jul 24, 2024
This was referenced Aug 7, 2024
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds notes about setting up the repo locally and making some assumptions about the dev flow of other contributors.
Related discussion: